Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move - Simulations - Interpreter #593

Open
clarus opened this issue Aug 19, 2024 · 2 comments
Open

Move - Simulations - Interpreter #593

clarus opened this issue Aug 19, 2024 · 2 comments
Assignees
Labels

Comments

@clarus
Copy link
Collaborator

clarus commented Aug 19, 2024

Write a simulation for the evaluation function execute_instruction in https://github.com/move-language/move-sui/blob/main/crates/move-vm-runtime/src/interpreter.rs

There might be a lot of dependencies to this function, that can be cut into smaller pull requests!

@clarus clarus added the Move label Aug 19, 2024
@InfiniteEchoes InfiniteEchoes self-assigned this Aug 19, 2024
@InfiniteEchoes
Copy link
Collaborator

With a check into the function signature of execute_instruction, I think the task can be divded based on the types appeared in the signature. I'm creating issues based on them:

    fn execute_instruction(
        pc: &mut u16,
        locals: &mut Locals,
        ty_args: &[Type],
        function: &Arc<Function>,
        resolver: &Resolver,
        interpreter: &mut Interpreter,
        gas_meter: &mut impl GasMeter,
        instruction: &Bytecode,
    ) -> PartialVMResult<InstrRet> { ... }

@clarus
Copy link
Collaborator Author

clarus commented Aug 20, 2024

OK, good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants