From a1fe4a4a1ddf11eff26f93341a7c3b898783d1de Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Felipe=20Corr=C3=AAa=20da=20Silva=20Sanches?= Date: Fri, 9 Aug 2024 02:18:31 -0300 Subject: [PATCH] Deprecation of Outline profile, and migration of its checks The Outline profile was also removed and its checks migrated to the Google Fonts profile. As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones. (issue #4801) --- CHANGELOG.md | 2 +- Lib/fontbakery/profiles/googlefonts.py | 10 +++++++++- Lib/fontbakery/profiles/outline.py | 12 ------------ docs/source/fontbakery/profiles/index.rst | 1 - docs/source/fontbakery/profiles/outline.rst | 5 ----- 5 files changed, 10 insertions(+), 20 deletions(-) delete mode 100644 Lib/fontbakery/profiles/outline.py delete mode 100644 docs/source/fontbakery/profiles/outline.rst diff --git a/CHANGELOG.md b/CHANGELOG.md index 7e116972ef..bc6ee7ec53 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,7 +4,7 @@ A more detailed list of changes is available in the corresponding milestones for ## Upcoming release: 0.12.10 (2024-Jul-??) ### Noteworthy code changes - The **UFO** profile was removed and its checks were migrated to the **Universal** profile. For that reason, all of them received a temporary "experimental" flag (issue #4801) - - The **shaping** profile was also removed and its checks migrated to the **Google Fonts** profile. As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones. (issue #4801) + - The **Shaping** and **Outline** profile were also removed and their checks migrated to the **Google Fonts** profile. As gfonts was already including those, and no other profile did so, there's no need to add experimental flags to these ones. (issue #4801) ### Changes to existing checks - **EXPERIMENTAL - [com.daltonmaag/check/consistent_curve_type]:**: remove usage of `ufoLib2` APIs. (PR #4802) diff --git a/Lib/fontbakery/profiles/googlefonts.py b/Lib/fontbakery/profiles/googlefonts.py index f5444c15ee..65f97d36b8 100644 --- a/Lib/fontbakery/profiles/googlefonts.py +++ b/Lib/fontbakery/profiles/googlefonts.py @@ -1,5 +1,5 @@ PROFILE = { - "include_profiles": ["universal", "outline"], + "include_profiles": ["universal"], "sections": { "Article Checks": [ "com.google.fonts/check/article/images", @@ -108,6 +108,14 @@ "com.google.fonts/check/dotted_circle", "com.google.fonts/check/soft_dotted", ], + "Outline Checks": [ + "com.google.fonts/check/outline_alignment_miss", + "com.google.fonts/check/outline_short_segments", + "com.google.fonts/check/outline_colinear_vectors", + "com.google.fonts/check/outline_jaggy_segments", + "com.google.fonts/check/outline_semi_vertical", + "com.google.fonts/check/outline_direction", + ], "Font File Checks": [ "com.google.fonts/check/aat", "com.google.fonts/check/canonical_filename", diff --git a/Lib/fontbakery/profiles/outline.py b/Lib/fontbakery/profiles/outline.py deleted file mode 100644 index 47e2fcc62a..0000000000 --- a/Lib/fontbakery/profiles/outline.py +++ /dev/null @@ -1,12 +0,0 @@ -PROFILE = { - "sections": { - "Outline Checks": [ - "com.google.fonts/check/outline_alignment_miss", - "com.google.fonts/check/outline_short_segments", - "com.google.fonts/check/outline_colinear_vectors", - "com.google.fonts/check/outline_jaggy_segments", - "com.google.fonts/check/outline_semi_vertical", - "com.google.fonts/check/outline_direction", - ] - } -} diff --git a/docs/source/fontbakery/profiles/index.rst b/docs/source/fontbakery/profiles/index.rst index dd7f2af506..46429e25b4 100644 --- a/docs/source/fontbakery/profiles/index.rst +++ b/docs/source/fontbakery/profiles/index.rst @@ -14,4 +14,3 @@ profiles fontwerk fontval iso15008 - outline diff --git a/docs/source/fontbakery/profiles/outline.rst b/docs/source/fontbakery/profiles/outline.rst deleted file mode 100644 index 54ed358958..0000000000 --- a/docs/source/fontbakery/profiles/outline.rst +++ /dev/null @@ -1,5 +0,0 @@ -####### -Outline -####### - -.. autoprofile:: fontbakery.profiles.outline