Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the distribution of the default skin #60

Closed
fmang opened this issue Feb 18, 2018 · 1 comment
Closed

Change the distribution of the default skin #60

fmang opened this issue Feb 18, 2018 · 1 comment
Assignees
Milestone

Comments

@fmang
Copy link
Owner

fmang commented Feb 18, 2018

Right now, the default skin is downloaded when make is run, unless it is already present.

Distribution tarballs are shipped with the samples for the regular user. That default skin accounts for a very large part of the weight of the tarball.

The alternative is to distribute 2 tarballs: one with the program, and one with the default skin (since it never changes), and make it easy for the packagers to integrate the skin if needed.

A rule make install-default-skin could provide a convenient way for the user to install the skin, or maybe a more complete oshu-skin command. If the skin is named .osk it makes it obvious the user is free to use another skin.

Now, it would be nice to include at least one default sample to ship with the program tarball so that the game remains playable without any skin. The -GN sample is a really nice candidate here, and solves #58.

Thank you @lanodan for your advice :)

Proposal for the directory structure:

/usr/share/oshu/skins/
    current (or default, as in OSHU_SKIN=default) -> gn
    gn/ (or min, default, standard, oshu) 
        normal-hitnormal.wav
        soft-hitnormal.wav -> normal-hitnormal.wav
        drum-hitnormal.wav -> normal-hitnormal.wav
    osu/
        normal-hitnormal.wav
        soft-hitnormal.wav
        ...
@fmang fmang added this to the 1.7 milestone Feb 18, 2018
@fmang fmang self-assigned this Feb 18, 2018
This was referenced Feb 25, 2018
@fmang
Copy link
Owner Author

fmang commented Feb 25, 2018

I managed to make all these things configurable at build time with CMake. The README contains the new details. In short: -DOSHU_DEFAULT_SKIN=osu makes cmake download and install the osu skin on top of the minimal one, and creates a default symlink :)

Next is #64.

@fmang fmang closed this as completed Feb 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant