Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[google_adsense] Add optional init parameters. #8297

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

ditman
Copy link
Member

@ditman ditman commented Dec 14, 2024

Adds AdSenseCodeParameters configuration object for adSense.initialize.

Fixes a typo in the MATCHED_CONTENT_ROWS_NUM and MATCHED_CONTENT_COLUMNS_NUM constants, that would have resulted in passing the wrong parameter name to the AdSense JS.

This PR also continues the tightening of exports by making all the exports from barrel files explicit, so it's harder to accidentally expose any unintended API surface.

Issues

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@ditman ditman requested a review from sokoloff06 as a code owner December 14, 2024 01:19
@ditman ditman requested review from mdebbar and sokoloff06 and removed request for sokoloff06 and mdebbar December 14, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant