[camera] Add API support query for image streaming #8250

liff · 2024-12-09T13:15:24Z

Add API support query, supportsImageStreaming for checking if the camera platform supports image streaming.

As requested on this comment: #8234 (comment)

Attempting to follow the contribution guide wrt. changing federated plugins.

There is no issue to link to, but should I create one?

Pre-launch Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

stuartmorgan

Thanks for the contribution!

stuartmorgan · 2024-12-09T15:58:49Z

packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart

@@ -173,6 +173,11 @@ abstract class CameraPlatform extends PlatformInterface {
    throw UnimplementedError('resumeVideoRecording() is not implemented.');
  }

+  /// Check whether this platform supports image streaming via [onStreamedFrameAvailable].
+  bool supportsImageStreaming() {
+    throw UnimplementedError('supportsImageStreaming() is not implemented.');


The default should be false, not to throw, so that existing implementations that don't support it will automatically get the right behavior.

stuartmorgan · 2024-12-09T15:59:59Z

packages/camera/camera_web/lib/src/camera_web.dart

@@ -661,6 +661,9 @@ class CameraPlugin extends CameraPlatform {
    );
  }

+  @override
+  bool supportsImageStreaming() => false;


The web and Windows package changes won't be necessary once the base implementation is changed.

Removed those changes.

stuartmorgan · 2024-12-09T16:03:41Z

packages/camera/camera/lib/src/camera_controller.dart

-  /// The `startImageStream` method is only available on Android and iOS (other
-  /// platforms won't be supported in current setup).
+  /// The `startImageStream` method is only available on platforms that
+  /// report support for image streaming via [CameraPlatform.supportsImageStreaming].


This needs to be wrapped in a method at this layer; clients are not expected to use the platform interface directly.

Added a method.

camsim99

Android changes LGTM!

liff · 2024-12-10T11:01:53Z

Android build is failing in Firebase Test Lab, but I don’t seem to have permission to view the results.

camsim99 · 2024-12-10T18:15:11Z

Android build is failing in Firebase Test Lab, but I don’t seem to have permission to view the results.

The Android image streaming test is failing:

java.lang.Exception: ══╡ EXCEPTION CAUGHT BY FLUTTER TEST FRAMEWORK ╞═════════════════
The following assertion was thrown running a test:
'package:camera/src/camera_controller.dart': Failed assertion:
line 488 pos 12: 'supportsImageStreaming()': is not true.

When the exception was thrown, this was the stack:
#2      CameraController.startImageStream (package:camera/src/camera_controller.dart:488:12)
#3      main.<anonymous closure> (file:///b/s/w/ir/x/w/packages/packages/camera/camera/example/integration_test/camera_test.dart:251:24)
<asynchronous suspension>
#4      testWidgets.<anonymous closure>.<anonymous closure> (package:flutter_test/src/widget_tester.dart:189:15)
<asynchronous suspension>
#5      TestWidgetsFlutterBinding._runTestBody (package:flutter_test/src/binding.dart:1027:5)
<asynchronous suspension>
#6      TestWidgetsFlutterBinding._createTestCompletionHandler.<anonymous closure> (package:flutter_test/src/binding.dart:824:12)
<asynchronous suspension>
(elided 2 frames from class _AssertionError)

The test description was:
  Android image streaming
═════════════════════════════════════════════════════════════════

	at dev.flutter.plugins.integration_test.FlutterTestRunner.run(FlutterTestRunner.java:84)
	at org.junit.runners.Suite.runChild(Suite.java:128)
	at org.junit.runners.Suite.runChild(Suite.java:27)
	at org.junit.runners.ParentRunner$3.run(ParentRunner.java:290)
	at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:71)
	at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:288)
	at org.junit.runners.ParentRunner.access$000(ParentRunner.java:58)
	at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:268)
	at org.junit.runners.ParentRunner.run(ParentRunner.java:363)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:137)
	at org.junit.runner.JUnitCore.run(JUnitCore.java:115)
	at androidx.test.internal.runner.TestExecutor.execute(TestExecutor.java:56)
	at androidx.test.runner.AndroidJUnitRunner.onStart(AndroidJUnitRunner.java:392)
	at android.app.Instrumentation$InstrumentationThread.run(Instrumentation.java:2361)

liff · 2024-12-11T11:00:16Z

I am unable to reproduce the failure locally with an emulator or with Firebase Test Lab.

I tried the integration tests with Firebase Test Lab both in camera/example and camera_android/example:

$ pushd android
$ ./gradlew app:assembleAndroidTest
$ ./gradlew app:assembleDebug -Ptarget=integration_test/camera_test.dart
$ popd
$ gcloud firebase test android run --type instrumentation --app build/app/outputs/apk/debug/app-debug.apk --test build/app/outputs/apk/androidTest/debug/app-debug-androidTest.apk --timeout 7m --device model=panther,version=33

But I get successful results:

camera_android

┌─────────┬────────────────────────┬─────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │     TEST_DETAILS    │
├─────────┼────────────────────────┼─────────────────────┤
│ Passed  │ panther-33-en-portrait │ 9 test cases passed │
└─────────┴────────────────────────┴─────────────────────┘

camera

┌─────────┬────────────────────────┬─────────────────────┐
│ OUTCOME │    TEST_AXIS_VALUE     │     TEST_DETAILS    │
├─────────┼────────────────────────┼─────────────────────┤
│ Passed  │ panther-33-en-portrait │ 4 test cases passed │
└─────────┴────────────────────────┴─────────────────────┘

and similar results with the emulator, except for this:

Failed assertion: line 89 pos 16: '!(!previousPresetExactlySupported && presetExactlySupported)'

in the “Capture specific image resolutions” test.

Any ideas as to what’s going on?

liff · 2024-12-11T12:16:54Z

Re-running the check seems to have solved the problem 🎉

stuartmorgan

The API changes look good to me; this is ready to split out the first sub-PR for landing.

I left notes about missing tests, but those can be addressed in the sub PRs.

stuartmorgan · 2024-12-13T15:59:06Z

packages/camera/camera_platform_interface/lib/src/platform_interface/camera_platform.dart

@@ -173,6 +173,9 @@ abstract class CameraPlatform extends PlatformInterface {
    throw UnimplementedError('resumeVideoRecording() is not implemented.');
  }

+  /// Check whether this platform supports image streaming via [onStreamedFrameAvailable].
+  bool supportsImageStreaming() => false;


This will need a Dart unit test.

stuartmorgan · 2024-12-13T15:59:21Z

packages/camera/camera_avfoundation/lib/src/avfoundation_camera.dart

@@ -237,6 +237,9 @@ class AVFoundationCamera extends CameraPlatform {
    await _hostApi.resumeVideoRecording();
  }

+  @override
+  bool supportsImageStreaming() => true;


This will need a Dart unit test.

stuartmorgan · 2024-12-13T15:59:31Z

packages/camera/camera_android_camerax/lib/src/android_camera_camerax.dart

@@ -1152,6 +1152,9 @@ class AndroidCameraCameraX extends CameraPlatform {
    }
  }

+  @override
+  bool supportsImageStreaming() => true;


This will need a Dart unit test.

stuartmorgan · 2024-12-13T15:59:42Z

packages/camera/camera_android/lib/src/android_camera.dart

@@ -228,6 +228,9 @@ class AndroidCamera extends CameraPlatform {
  Future<void> resumeVideoRecording(int cameraId) =>
      _hostApi.resumeVideoRecording();

+  @override
+  bool supportsImageStreaming() => true;


This will need a Dart unit test.

liff requested review from cbracken, hellohuanlin, camsim99, ditman and bparrishMines as code owners December 9, 2024 13:15

github-actions bot added p: camera platform-android platform-ios platform-macos platform-web platform-windows labels Dec 9, 2024

liff mentioned this pull request Dec 9, 2024

[camera_windows] Restore image streaming support #8234

Open

11 tasks

liff force-pushed the supportsImageStreaming branch 3 times, most recently from 3d16044 to 4d88109 Compare December 9, 2024 15:37

stuartmorgan requested changes Dec 9, 2024

View reviewed changes

camsim99 reviewed Dec 9, 2024

View reviewed changes

hellohuanlin approved these changes Dec 9, 2024

View reviewed changes

liff force-pushed the supportsImageStreaming branch from 4d88109 to b87babe Compare December 10, 2024 07:45

github-actions bot removed platform-web platform-windows labels Dec 10, 2024

liff requested a review from stuartmorgan December 10, 2024 07:47

liff force-pushed the supportsImageStreaming branch 2 times, most recently from 2927697 to ead8c41 Compare December 10, 2024 19:40

liff added 2 commits December 13, 2024 09:48

[camera_platform_interface] Add API support query for image streaming

9beadb6

[camera_android] Add API support query for image streaming

e9f3029

liff added 3 commits December 13, 2024 09:48

[camera_android_camerax] Add API support query for image streaming

4a83a48

[camera_avfoundation] Add API support query for image streaming

8065913

[camera] Add API support query for image streaming

247846d

liff force-pushed the supportsImageStreaming branch from ead8c41 to 247846d Compare December 13, 2024 07:50

stuartmorgan reviewed Dec 13, 2024

View reviewed changes

stuartmorgan removed request for cbracken and ditman December 13, 2024 16:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[camera] Add API support query for image streaming #8250

[camera] Add API support query for image streaming #8250

liff commented Dec 9, 2024 •

edited

Loading

stuartmorgan left a comment

stuartmorgan Dec 9, 2024

liff Dec 10, 2024

stuartmorgan Dec 9, 2024

liff Dec 10, 2024

stuartmorgan Dec 9, 2024

liff Dec 10, 2024

camsim99 left a comment •

edited

Loading

liff commented Dec 10, 2024

camsim99 commented Dec 10, 2024

liff commented Dec 11, 2024

liff commented Dec 11, 2024

stuartmorgan left a comment

stuartmorgan Dec 13, 2024

stuartmorgan Dec 13, 2024

stuartmorgan Dec 13, 2024

stuartmorgan Dec 13, 2024

[camera] Add API support query for image streaming #8250

Are you sure you want to change the base?

[camera] Add API support query for image streaming #8250

Conversation

liff commented Dec 9, 2024 • edited Loading

Pre-launch Checklist

stuartmorgan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

camsim99 left a comment • edited Loading

Choose a reason for hiding this comment

liff commented Dec 10, 2024

camsim99 commented Dec 10, 2024

liff commented Dec 11, 2024

camera_android

camera

liff commented Dec 11, 2024

stuartmorgan left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

liff commented Dec 9, 2024 •

edited

Loading

camsim99 left a comment •

edited

Loading