[shared_preferences] Fix JSON parsing issue with _decodeValue #8211
+64
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stuartmorgan
requested changes
Dec 3, 2024
packages/shared_preferences/shared_preferences_web/lib/shared_preferences_web.dart
Outdated
Show resolved
Hide resolved
packages/shared_preferences/shared_preferences_web/lib/shared_preferences_web.dart
Outdated
Show resolved
Hide resolved
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
2 times, most recently
from
17b9578 to
daf7473
Compare
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
from
daf7473 to
be1e837
Compare
stuartmorgan
approved these changes
Dec 5, 2024
...preferences/shared_preferences_web/example/integration_test/shared_preferences_web_test.dart
Outdated
Show resolved
Hide resolved
...preferences/shared_preferences_web/example/integration_test/shared_preferences_web_test.dart
Outdated
Show resolved
Hide resolved
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
3 times, most recently
from
fae6a8b to
efbb8a4
Compare
Dan-Crane
force-pushed
the
fix-shared-pref-web-parsing
branch
from
efbb8a4 to
768cdd6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[shared_preferences] Fix JSON parsing issue with getAllWithParameters
this is a restored PR #5813
Fixes flutter/flutter#156574
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style], or this PR is [exempt from CHANGELOG changes].///).https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog-style
[exempt from CHANGELOG changes]: https://github.com/flutter/flutter/blob/master/docs/ecosystem/contributing/README.md#changelog
[test-exempt]: https://github.com/flutter/flutter/blob/master/docs/contributing/Tree-hygiene.md#tests