Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ghost ESP #566

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Ghost ESP #566

wants to merge 17 commits into from

Conversation

jaylikesbunda
Copy link

@jaylikesbunda jaylikesbunda commented Nov 27, 2024

Application Submission

  • App for interfacing with the Ghost ESP firmware

Extra Requirements

  • Requires an ESP32 GPIO Add-on
  • Requires Ghost ESP Firmware Flashed on ESP32

Author Checklist (Fill this out)

  • I've read the contribution guidelines and my PR follows them
  • I own the code I'm submitting or have code owner's permission to submit it
  • I have validated the manifest file(s) with python3 tools/bundle.py --nolint applications/CATEGORY/APPID/manifest.yml bundle.zip

Reviewer Checklist (Don't fill this out)

  • Bundle is valid
  • There are no obvious issues with the source code
  • I've ran this application and verified its functionality

@doomwastaken doomwastaken self-assigned this Nov 28, 2024
@doomwastaken doomwastaken added app (new) QA pending To be reviewed by QA labels Nov 28, 2024
@doomwastaken doomwastaken added fixes needed Unresolved issues with the app requiring maintainer's attention and removed QA pending To be reviewed by QA labels Dec 5, 2024
@doomwastaken
Copy link
Member

Greetings! Had to check through the code what is the issue with build. We are matching fields in manifest / .fam file field by field and if they mismatch, we get this error, there are differences in manifest and app.fam files currently.

@jaylikesbunda
Copy link
Author

Greetings! Had to check through the code what is the issue with build. We are matching fields in manifest / .fam file field by field and if they mismatch, we get this error, there are differences in manifest and app.fam files currently.

thanks for clarifying! i think i fixed it up but the ofw version will have to be in another branch since the main branch .fam uses the GPIO/ESP folder which i don't think exists in ofw as far as i'm aware

@doomwastaken
Copy link
Member

Targets must be "targets: ['all']", that is hardware targets that we have in flipper zero. For example early versions were f6 and current generation is f7. Hence 'all' that is being supported by our build system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
app (new) fixes needed Unresolved issues with the app requiring maintainer's attention
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants