Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Add instructions for adding keyboard shortcut to Ubuntu 22.04 #2609

Merged
merged 1 commit into from
May 19, 2022

Conversation

henetiriki
Copy link
Contributor

No description provided.

@borgmanJeremy borgmanJeremy requested a review from mmahmoudian May 17, 2022 14:36
@mmahmoudian
Copy link
Member

@henetiriki Thank you for the PR. I just wonder if we should emphasis on the fact that this is Gnome-specific and it would be exactly the same regardless of distro. Right?

@henetiriki
Copy link
Contributor Author

That is true. Unfortunately I don't know which instructions apply to which versions of Gnome. I only discovered this tool this week and the instructions I've added works for Gnome 42.

Shall I revert my changes to the Ubuntu instructions and rather add a Gnome section starting Gnome 42?

@mmahmoudian
Copy link
Member

Let's merge it for now, and then we have to probably create sub pages for each DE and move these instructions there. Our README is getting extremely lengthy and overwhelming for users.

@borgmanJeremy borgmanJeremy merged commit 0ecb4ee into flameshot-org:master May 19, 2022
@borgmanJeremy
Copy link
Contributor

Thank you!

panpuchkov pushed a commit to namecheap/flameshot that referenced this pull request Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants