Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adding paint attribute to SpriteWidget and SpriteAnimationWidget #3298

Merged
merged 3 commits into from
Sep 12, 2024

Conversation

erickzanardo
Copy link
Member

Description

Adds a Paint attribute to the SpriteWidget and SpriteAnimationWidget for an improved API.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

@erickzanardo erickzanardo requested a review from a team September 11, 2024 21:54
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm! Does this need to be added to the other widgets?

packages/flame/lib/src/widgets/animation_widget.dart Outdated Show resolved Hide resolved
packages/flame/lib/src/widgets/sprite_widget.dart Outdated Show resolved Hide resolved
@erickzanardo erickzanardo enabled auto-merge (squash) September 12, 2024 12:13
@erickzanardo
Copy link
Member Author

Lgtm! Does this need to be added to the other widgets?

Hm, that is a good idea, I will merge this, but I will check if it makes sense on them, It mostly likely does, at least on NineTileBox one from what I remember

@erickzanardo erickzanardo merged commit a5338d0 into main Sep 12, 2024
8 checks passed
@erickzanardo erickzanardo deleted the feat/widget-paint-attr branch September 12, 2024 12:19
luanpotter pushed a commit that referenced this pull request Oct 15, 2024
#3298)

Adds a `Paint` attribute to the `SpriteWidget` and
`SpriteAnimationWidget` for an improved API.

---------

Co-authored-by: Lukas Klingsbo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants