Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Export TapConfig to make visible #3323

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

lucasnlm
Copy link
Contributor

Description

A few time ago I added TapConfig class. It allows us to config the tap timing.
However, it's not exported. This PR fix this problem.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon spydon changed the title feat: Export TapConfig to make visible fix: Export TapConfig to make visible Sep 30, 2024
@spydon spydon enabled auto-merge (squash) September 30, 2024 03:50
@spydon spydon merged commit 8e00115 into flame-engine:main Sep 30, 2024
9 checks passed
luanpotter pushed a commit that referenced this pull request Oct 15, 2024
# Description
A few time ago I added TapConfig class. It allows us to config the tap
timing.
However, it's not exported. This PR fix this problem.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants