-
-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Adding x,y,width and height inputs to position components on Dev Tools #3263
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no polling for the attributes if they change within the game currently right? Just check if I missed that, or if it's maybe planned as a follow-up? :)
packages/flame/lib/src/devtools/connectors/position_attributes_component_connector.dart
Outdated
Show resolved
Hide resolved
import 'package:flame_devtools/widgets/incremental_number_form_field.dart'; | ||
import 'package:flutter/material.dart'; | ||
|
||
class PositionComponentAttributesForm extends StatefulWidget { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class PositionComponentAttributesForm extends StatefulWidget { | |
class PositionComponentAttributesForm extends ConsumerWidget { |
packages/flame_devtools/lib/widgets/position_component_attributes_form.dart
Outdated
Show resolved
Hide resolved
I did not implemented that indeed, tbh, that didn't even crossed my mind hahha, I guess my creativity is not what it used to be... It is a good idea though! Should we make a refresh button like the component tree or just go straight into a pooling??? |
I think polling would be more user friendly, but maybe problematic when the user wants to set the values of something that is moving/resizing... Maybe just not updating the values while the user is in the text field. |
@erickzanardo will it be possible to add some titles to the properties? Like |
Changed to look like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm!!
Description
Adds fields to allow developers to change the x, y, width and height of position components from the dev tools.
position_2.mp4
Checklist
docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues