Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add assertion when trying to set "current" that doesn't exist #3258

Merged
merged 6 commits into from
Aug 9, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Aug 8, 2024

Description

Currently when setting current in SpriteAnimationGroupComponent and SpriteGroupComponent we silently fail if the key isn't in the map. This PR adds assertions so that we at least warn about it in debug mode.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@erickzanardo
Copy link
Member

Maybe we could add some tests for the assertions?

@spydon spydon enabled auto-merge (squash) August 9, 2024 17:12
Copy link
Member

@luanpotter luanpotter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@spydon spydon merged commit 267d680 into main Aug 9, 2024
8 checks passed
@spydon spydon deleted the fix/add-assert-when-setting-current branch August 9, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants