Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Take in super.curve in ScalingParticle #3220

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

duck-dev-go
Copy link
Contributor

@duck-dev-go duck-dev-go commented Jul 11, 2024

feat: Take in curve parameter in ScalingParticle

This PR introduces a curve parameter to the ScalingParticle class. This allows for more flexible and customizable scaling by specifying different curves for scaling transformations. The default curve is set to Curves.linear, ensuring backward compatibility.

Checklist

  • I have followed the [Contributor Guide] when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

@spydon spydon changed the title Take in super.curve in ScalingParticle feat: Take in super.curve in ScalingParticle Jul 11, 2024
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@duck-dev-go duck-dev-go force-pushed the curved-scale-particles branch from a300c0b to 6549b29 Compare July 11, 2024 19:54
@duck-dev-go
Copy link
Contributor Author

Lgtm!

I ended up committing on the same branch and had to reset to the previous commit. My bad. Nothing changed.

@spydon spydon merged commit 0fbc73c into flame-engine:main Jul 11, 2024
17 of 18 checks passed
@duck-dev-go duck-dev-go deleted the curved-scale-particles branch July 11, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants