Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add pause and resume to HasTimeScale mixin #3216

Merged
merged 2 commits into from
Jul 9, 2024
Merged

feat: Add pause and resume to HasTimeScale mixin #3216

merged 2 commits into from
Jul 9, 2024

Conversation

ufrshubham
Copy link
Member

Description

This PR just adds 2 simple method to easily pause and resume the time scaled component.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Related Issues

NA

spydon
spydon approved these changes Jul 9, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it weekend in India already? We must have a bigger timezone difference than I thought ;D
LGTM!

@spydon spydon merged commit 9a86e7b into main Jul 9, 2024
8 checks passed
@spydon spydon deleted the devkage/pause-resume-time-scale branch July 9, 2024 19:32
@ufrshubham
Copy link
Member Author

Is it weekend in India already? We must have a bigger timezone difference than I thought ;D
LGTM!

Or I might have time traveled and sent the PR from future 😜

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ufrshubham @spydon