Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor!: Use HasTimeScale for Route #3064

Merged
merged 1 commit into from
Mar 3, 2024
Merged

refactor!: Use HasTimeScale for Route #3064

merged 1 commit into from
Mar 3, 2024

Conversation

ufrshubham
Copy link
Member

Description

This PR replaces the Route.timeSpeed with HasTimeScale.timeScale.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • Yes, this PR is a breaking change.
  • No, this PR is not a breaking change.

Migration instructions

Replace Route.timeSpeed with Route.timeScale.

Related Issues

NA

spydon
spydon approved these changes Mar 3, 2024
View reviewed changes
Copy link
Member

@spydon spydon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and I think quite few use this API so it shouldn't a too bad breaking change

@spydon spydon merged commit 30fde80 into main Mar 3, 2024
8 checks passed
@spydon spydon deleted the devkage/has-time-scale-for-route branch March 3, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spydon spydon spydon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ufrshubham @spydon