Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial functionality of flame_devtools #3061

Merged
merged 9 commits into from
Mar 5, 2024
Merged

Conversation

spydon
Copy link
Member

@spydon spydon commented Mar 2, 2024

Description

image

This adds a structure and some basic functionality for the Flame devtools extension.

Later I will add a pre/post-hook for publishing to Melos so that it can build the devtools extension before publishing (and remove the directory afterwards), since it isn't committed to this repository. For now one has to run melos devtools-build before publishing.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon requested a review from a team March 2, 2024 12:21
Copy link
Member

@ufrshubham ufrshubham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Added some minor comments.

Copy link
Member

@renancaraujo renancaraujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super cool

packages/flame_devtools/lib/widgets/component_counter.dart Outdated Show resolved Hide resolved
packages/flame_devtools/.gitignore Outdated Show resolved Hide resolved
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor nits, but LGTM

@spydon spydon merged commit c92910c into main Mar 5, 2024
8 checks passed
@spydon spydon deleted the feat/flame_devtools branch March 5, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants