Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Vertices in PolygonComponent should subtract vertices positioning #3040

Merged
merged 3 commits into from
Feb 16, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Feb 15, 2024

Description

If the vertices in the PolygonComponent weren't starting at 0,0 they got the wrong hitbox, but rendered correctly.
This PR fixes that.

Closes: #3031

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

@spydon spydon merged commit 4f053ed into main Feb 16, 2024
8 checks passed
@spydon spydon deleted the fix/polygon-component-vertices branch February 16, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PolygonComponent does not respond to hover and click event regions
3 participants