Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Lifecycle completers to be called for FlameGame #3007

Merged
merged 5 commits into from
Jan 28, 2024
Merged

fix: Lifecycle completers to be called for FlameGame #3007

merged 5 commits into from
Jan 28, 2024

Conversation

spydon
Copy link
Member

@spydon spydon commented Jan 27, 2024 •
edited
Loading

Description

Previously the mounted, loaded and removed completers for FlameGame weren't called since FlameGame doesn't go through the normal component lifecycle flow, this PR adds so that the completers are completed properly.

Checklist

  • I have followed the Contributor Guide when preparing my PR.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples or docs.

Breaking Change?

  • No, this PR is not a breaking change.

Related Issues

Closes #3003

@spydon spydon changed the title fix: Lifecycle completers mounted/loaded called for FlameGame fix: Lifecycle completers to be called for FlameGame Jan 27, 2024
@spydon spydon mentioned this pull request Jan 27, 2024
Closed
erickzanardo
erickzanardo approved these changes Jan 27, 2024
View reviewed changes
Copy link
Member

@erickzanardo erickzanardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of doubts. But LGTM already

packages/flame/lib/src/components/core/component.dart Show resolved Hide resolved
packages/flame/lib/src/game/game_widget/game_widget.dart Show resolved Hide resolved
@spydon spydon merged commit 3804f52 into main Jan 28, 2024
8 checks passed
@spydon spydon deleted the fix/game-completers branch January 28, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erickzanardo erickzanardo erickzanardo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make loaded,mounted and removed Futures on FlameGame instance working
2 participants
@spydon @erickzanardo