Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[firebase_messaging] Please add, subscribed and unsubscribe with a specific callback, where you can find out if it was done with successes or mistakes. #3785

Closed
Romavic opened this issue Oct 6, 2020 · 3 comments · Fixed by #4012
Labels
plugin: messaging resolution: solution-provided A solution has been provided in the issue.

Comments

@helenaford helenaford changed the title Please add, subscribed and unsubscribe with a specific calback, where you can find out if it was done with successes or mistakes. [firebase_messaging] Please add, subscribed and unsubscribe with a specific callback, where you can find out if it was done with successes or mistakes. Oct 6, 2020
@helenaford
Copy link
Contributor

helenaford commented Oct 6, 2020

Hey, not sure about the current version, but in the rework (which is in progress), if they fail an error will be thrown. The behaviour is described in the native docs
For cases where the subscription cannot be completed, the subscription throws an error that you can catch...

I believe this way is preferred way to see the error from native sdk. Also, keeps in line with the rest of the plugins and the API.

@helenaford helenaford added the blocked: customer-response Waiting for customer response, e.g. more information was requested. label Oct 6, 2020
@Romavic
Copy link
Author

Romavic commented Oct 8, 2020

@helenaford thanks for answer me... now i understood.

@google-oss-bot google-oss-bot added Needs Attention This issue needs maintainer attention. and removed blocked: customer-response Waiting for customer response, e.g. more information was requested. labels Oct 8, 2020
@TahaTesser TahaTesser removed the Needs Attention This issue needs maintainer attention. label Oct 8, 2020
@TahaTesser
Copy link

Hi @helenaford
If this is already addressed in rework, can we close this issue?
Thank you

@TahaTesser TahaTesser added the resolution: solution-provided A solution has been provided in the issue. label Oct 8, 2020
@Romavic Romavic closed this as completed Oct 8, 2020
@firebase firebase locked and limited conversation to collaborators Nov 8, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
plugin: messaging resolution: solution-provided A solution has been provided in the issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants