Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[📚] Conflicting docs for Firebase Messaging (CHANGE ME) #3469

Closed
deadsoul44 opened this issue Sep 5, 2020 · 4 comments
Closed

[📚] Conflicting docs for Firebase Messaging (CHANGE ME) #3469

deadsoul44 opened this issue Sep 5, 2020 · 4 comments
Labels
good first issue Good for newcomers plugin: messaging type: documentation Improvements or additions to documentation

Comments

@deadsoul44
Copy link

In firebase_messaging readme, you say add firebase_messaging dependency to app/build.gradle:

https://pub.dev/packages/firebase_messaging#getting-started

readme

But in migration guide, you say remove any firebase product dependency from app/build.gradle:

https://firebase.flutter.dev/docs/migration/#a-android-installation

migration

Which one is correct?

@prakharb10
Copy link

Hi, I'd like to work on this

@alfredobs97
Copy link

Hey!
I see the migration guide and I remove the dependency in build.gradle but it doesn´t work so I think the correct is the first documentation and you have to set the firebase-messaging dependency

@Abhishek01039
Copy link
Contributor

Hello @prakharb10
#4012
This reverts the docs
Please see this https://pub.dev/packages/firebase_messaging/versions/8.0.0-dev.9
Thanks

@Salakar
Copy link
Member

Salakar commented Dec 6, 2020

The one on pub currently in your screenshot is the old stable version. The new website and migration guide is for the dev release as @Abhishek01039 mentioned above.

This will be promoted to stable in a few days.

@Salakar Salakar closed this as completed Dec 6, 2020
@firebase firebase locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers plugin: messaging type: documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

6 participants