Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVM: Remove manual error destructuring #1370

Closed
Stebalien opened this issue Jan 2, 2023 · 4 comments
Closed

EVM: Remove manual error destructuring #1370

Stebalien opened this issue Jan 2, 2023 · 4 comments
Milestone

Comments

@Stebalien
Copy link
Member

We occasionally use manual error matching in the EVM (https://github.com/filecoin-project/builtin-actors/blob/e1ef665b2f2dca1448c04c9b439e9cdbc9e0b511/actors/evm/src/interpreter/execution.rs#L255-L259) instead of the question mark operator.

However, the perf issue was apparently fixed in rust-lang/rust#100693, which got included in 1.64 (which we now use). We should verify that these if let and match statements are no longer performance critical, and remove them.

@maciejwitowski
Copy link
Contributor

@Stebalien which milestone and priority?

@Stebalien Stebalien added this to the M2.2 milestone Jan 3, 2023
@mriise
Copy link
Contributor

mriise commented Jan 5, 2023

This should be a low-ish priority item since this is code style / cleanliness

@Stebalien
Copy link
Member Author

Yep. It's in M2.2.

@Stebalien Stebalien modified the milestones: M2.2, NV19 Feb 24, 2023
@Stebalien
Copy link
Member Author

And.... no. It might be the map_err call, but it's still about 1% slower.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants