Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate flaky test caused by ignore lastWork on selecting mining candidate #12704

Open
masih opened this issue Nov 19, 2024 · 0 comments
Open

Comments

@masih
Copy link
Member

masih commented Nov 19, 2024

I think this may have introduced a shutdown race that's caused at least one flaky test in CI: https://github.com/filecoin-project/lotus/actions/runs/11851664737/job/33028560392#step:9:1189

failed to create block:
    github.com/filecoin-project/lotus/miner.(*Miner).mineOne
        /home/runner/work/lotus/lotus/miner/miner.go:634
  - failed to process messages from block template:
    github.com/filecoin-project/lotus/chain/consensus/filcns.(*FilecoinEC).CreateBlock
        /home/runner/work/lotus/lotus/chain/consensus/filcns/mine.go:32
  - building bls amt:
    github.com/filecoin-project/lotus/chain/consensus.CreateBlockHeader
        /home/runner/work/lotus/lotus/chain/consensus/common.go:411
  - badger blockstore closed

I can't come up with a theory about why that might be new with this change because I can imagine how it could happen with the older code (not checking m.stop in at least one more place).

Originally posted by @rvagg in #12690 (comment)

@github-project-automation github-project-automation bot moved this to 📌 Triage in FilOz Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 📌 Triage
Development

No branches or pull requests

1 participant