Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authz support (delegator claim bug) #82

Closed
bryanchriswhite opened this issue Sep 8, 2022 · 0 comments · Fixed by #124, #147 or #163
Closed

Authz support (delegator claim bug) #82

bryanchriswhite opened this issue Sep 8, 2022 · 0 comments · Fixed by #124, #147 or #163
Labels
C-bug Category: Something isn't working C-enhancement Category: New feature or request

Comments

@bryanchriswhite
Copy link

bryanchriswhite commented Sep 8, 2022

Background

It seems that when authz actions happen differently than their vanilla counterparts.

It looks like the nested messages may still be encoded with protobuf, in which case we will need to decode them in the handler.

Example authz message body (see investigation-query.gql):

{
  "grantee": "fetch1m5hgzum68rjf4c7zhezgkj8hlnmr0kgh9uj0g8",
  "msgs": [
    {
      "typeUrl": "/cosmos.distribution.v1beta1.MsgWithdrawDelegatorReward",
      "value": {
        "0": 10,
        "1": 44,
        "2": 102,
        ...
    }
  },
  {
    "typeUrl": "/cosmos.staking.v1beta1.MsgDelegate",
    "value": {
      "0": 10,
      "1": 44,
      "2": 102,
      ...
    }
  ]
}

Acceptance Criteria

Handler exists for authz's MsgExec message which:

  • checks that it's transaction was successful and bails if not
  • decodes the message's Msgs and calls the primitive message handler, and any respective message handler function
@bryanchriswhite bryanchriswhite changed the title Delegator claim invariant / assumption broken Authz support (delegator claim bug) Sep 13, 2022
@bryanchriswhite bryanchriswhite self-assigned this Sep 13, 2022
@bryanchriswhite bryanchriswhite added C-bug Category: Something isn't working C-enhancement Category: New feature or request labels Sep 13, 2022
This was linked to pull requests Oct 12, 2022
@bryanchriswhite bryanchriswhite removed their assignment Oct 26, 2022
@bryanchriswhite bryanchriswhite linked a pull request Nov 3, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-bug Category: Something isn't working C-enhancement Category: New feature or request
Projects
None yet
1 participant