Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added secure connection with certificate #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dyohan9
Copy link

@dyohan9 dyohan9 commented Mar 12, 2021

This will allow the grpc server to also be able to run using certificates making the client's connection to the server secure.

#2
#12

@dyohan9
Copy link
Author

dyohan9 commented Mar 19, 2021

hello, could you review? @fengsp

@dyohan9
Copy link
Author

dyohan9 commented Aug 4, 2021

Hi @fengsp, could you review?

@fengsp
Copy link
Owner

fengsp commented Aug 21, 2021

@dyohan9 Adding secure connection support is good 👍 . I might use grpc_settings to set up this, just like interceptors config, so that we have more flexibility, we have grpc.ssl_server_credentials and grpc.dynamic_ssl_server_credentials, so we could let users config one ServerCredentials instance in grpc_settings and use it, now users can choose whatever method to create a ServerCredentials. Any better idea?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants