Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent discriminator API #247

Closed
makslevental opened this issue Aug 2, 2018 · 2 comments
Closed

Inconsistent discriminator API #247

makslevental opened this issue Aug 2, 2018 · 2 comments
Labels
bug

Comments

@makslevental
Copy link
Contributor

can someone explain to me why every handler (find, get, update, patch) expects the discriminiatorKey to be inside params.query but the create handler expects it to be inside data?
@daffl
Copy link
Member

daffl commented Aug 6, 2018

Probably no reason. A pull request with a fix would be welcome.

@makslevental makslevental mentioned this issue Aug 8, 2018
Merged
@daffl daffl added the bug label Aug 31, 2018
@daffl
Copy link
Member

daffl commented Oct 3, 2018

Closed via #253, thank you for the pull request 😄

@daffl daffl closed this as completed Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daffl @makslevental