fix setUpdatedAt and setCreatedAt #46
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks very much for the catch! |
eddyystop
added a commit
that referenced
this pull request
Nov 29, 2016
- #46 - wrote tests to cover this fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The docs for
setCreatedAtand setUpdatedAt` says that they "Set the fields to the current date-time" but they set the date when the feathers application bootstraps.That's because the
new Datefunction is called during the bootstrap and not every time the hook is triggered. To solve that, I've changed thesetFieldmethod so that now it can accept a function as second argument and it will call it when the hook is actually triggered.