fix: isProvider returns a boolean #444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j2L4e
suggested changes
Sep 17, 2018
types/index.d.ts
Outdated
| @@ -210,7 +210,7 @@ export function getItems(context: HookContext): any; // any[] | any | undefined; | |||
| * Check which transport provided the service call. | |||
| * {@link https://feathers-plus.github.io/v1/feathers-hooks-common/index.html#IsProvider} | |||
| */ | |||
| export function isProvider(...transports: TransportName[]): PredicateFn; | |||
| export function isProvider(...transports: TransportName[]): boolean; | |||
There was a problem hiding this comment.
this is not correct, it should return "SyncPredicateFn", would you also please fix the test?
|
test still needs fixing, change the expected type to |
|
I'm such a noob, sorry for steeling your time... |
|
Now I think I understand what you mean with "fix the tests" |
|
don't worry. I was referring to |
|
Fixed tests.ts. Travis looks good? |
|
Great, thanks :) |
|
Published as v4.17.6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Eddy,
as discussed on Slack, I think the
isProvidermethod is returning aboolean.The usage of it should therefore be changed in the docs as well I guess to something like: