Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecated pluck and client hooks #283

Merged
merged 1 commit into from
Nov 14, 2017
Merged

Deprecated pluck and client hooks #283

merged 1 commit into from
Nov 14, 2017

Conversation

eddyystop
Copy link
Collaborator

No description provided.

@eddyystop eddyystop merged commit e1184d6 into master Nov 14, 2017
@eddyystop eddyystop deleted the deprecate branch November 14, 2017 18:33
@daffl
Copy link
Member

daffl commented Nov 14, 2017

The next version this is going to be published with has breaking changes anyway, why not just remove them?

@eddyystop
Copy link
Collaborator Author

I was also planning to

  • write keepQuery, deprecate pluckQuery
  • write discardQuery, deprecate removeQuery
  • deprevate setCreateAt and setUpdateAt for setNow('createdAt') and setNow('updatedAt')

They would all have to be manually changed.

@eddyystop
Copy link
Collaborator Author

I've thought about this. Changing Feathers core is pretty much an all or nothing thing. It doesn't make much sense to deprecate features.

I feel people will be challenged enough (time-wise, etc.) converting to the new Feathers core. I also feel its a good idea to not require them to handle hooks that disappeared without warning before they can even start testing the new core on their app.

I dislike old stuff lying around but I'll do it to help the users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants