Removed overly complex promisify function wrappers #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Function signatures were parsed to get the #params in a function and to see if the func was likely a callback func. There were some manageable issues with signatures whose params had default values. However the parser used does not work for params using deconstruction, and those are common. We would have to switch to a parser that parses signatures into an Abstract SyntaxTree to solve this problem. That is really going too far for the small benefits any parsing provides. - Removed all the promisify func except fnPromisfyCallback - Renamed fnPromisifyCall to the more descriptive callbackToPromise - Removed tests related to promisfy funcs - Updated test for callbackToPromise - Updated README. - Closed issue reminding us to remove hacks to get around Node 4.
|
Looks good @eddyystop! I think this is a good call. Simpler = better. Likely will need to be a major release I guess.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Function signatures were parsed to get the #params in a function
and to see if the func was likely a callback func. There were
some manageable issues with signatures whose params had default
values. However the parser used does not work for params using
deconstruction, and those are common. We would have to switch to
a parser that parses signatures into an Abstract SyntaxTree to
solve this problem. That is really going too far for the small
benefits any parsing provides.