Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate hook too limited #50

Closed
KidkArolis opened this issue Nov 25, 2016 · 3 comments
Closed

Validate hook too limited #50

KidkArolis opened this issue Nov 25, 2016 · 3 comments

Comments

@KidkArolis
Copy link
Contributor

I'd like to do some async validation and use app and some services to do so, but the default validation hook is only useful for very basic stuff that can be done locally with the data provided.

I started wrapping my validation in a higher order function to pass the app, but hooks/index.js that feathers generates are straight up functions.

@KidkArolis
Copy link
Contributor Author

Suggestion, I guess, is to pass hooks as the 2nd arg to the validate fn in addition to data.

@eddyystop
Copy link
Collaborator

eddyystop commented Nov 26, 2016 via email

eddyystop added a commit that referenced this issue Jan 18, 2017
- #50
- validation fcn provided to validate hook now also gets the hook as a param
@eddyystop
Copy link
Collaborator

#109

This will be available in feathers-hooks-common v3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants