Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preventChanges - add an option #275

Closed
eddyystop opened this issue Nov 1, 2017 · 2 comments
Closed

preventChanges - add an option #275

eddyystop opened this issue Nov 1, 2017 · 2 comments
Labels
enhancement

Comments

@eddyystop
Copy link
Collaborator

preventChanges presently throws is a patch is mutating given fields. An option to just remove those fields from context.data and continue with the patch may be useful.
@eddyystop
Copy link
Collaborator Author

The cleanest implemention may be a discardChanges hook. That would be yet another tiny hook. Any better suggestions?

@eddyystop
Copy link
Collaborator Author

Changed signature in Buzzard version: https://feathers-plus.github.io/v1/feathers-hooks-common/index.html#preventchanges . Deprecated old signature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@eddyystop