Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

softDelete preliminary get should not cause populate to run #270

Closed
eddyystop opened this issue Oct 23, 2017 · 2 comments
Closed

softDelete preliminary get should not cause populate to run #270

eddyystop opened this issue Oct 23, 2017 · 2 comments

Comments

@eddyystop
Copy link
Collaborator

It isn't possible to write a general hook which calls another service which will handle every possible case. The problem is you just cannot set up hook.params for the inner call in a way that satifies everyone for every case. softDelete makes such a call and runs into these issues. I suggest you fork softDelete and change https://github.com/feathers-plus/feathers-hooks-common/blob/master/src/services/soft-delete.js#L58-L64 so that on a get it sets hook.params._populate === 'skip', so populate skips the call.

@eddyystop
Copy link
Collaborator Author

softDelete2 is a noteable improvement over softDelete and should be used instead.

@eddyystop
Copy link
Collaborator Author

Published as v4.15.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant