Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module_0 not working due to changes in AWS bucket #18

Open
pmayd opened this issue Jul 6, 2023 · 3 comments
Open

Module_0 not working due to changes in AWS bucket #18

pmayd opened this issue Jul 6, 2023 · 3 comments

Comments

@pmayd
Copy link

pmayd commented Jul 6, 2023

It seems you no longer can attach ACL to buckets, see: terraform-aws-modules/terraform-aws-s3-bucket#223. I removed the following resource from main.tf and was able to deploy

resource "aws_s3_bucket_acl" "feast_bucket_acl" {
  bucket = aws_s3_bucket.feast_bucket.bucket
  acl    = "private"
}
@redhatHameed
Copy link

found the same issue and resolved it by updating the main.tf file under infra/aws with the following lines

resource "aws_s3_bucket_ownership_controls" "feast_bucket_acl" {
  bucket = aws_s3_bucket.feast_bucket.bucket
  rule {
    object_ownership = "BucketOwnerPreferred"
  }
}

@jeremyary
Copy link

good find @redhatHameed, thanks! Adding a small note that order is important, so the addition to main.tf needs to be above line 10 - this worked when I added to the top of the file underneath provider, but failed when I had just appended to bottom.

@redhatHameed
Copy link

@jeremyary agree here is PR to fix that #19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants