Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ttl as public field for Document #254

Merged
merged 3 commits into from
May 6, 2024
Merged

Add ttl as public field for Document #254

merged 3 commits into from
May 6, 2024

Conversation

ptpaterson
Copy link
Contributor

closes #240

Problem

ttl can be set on a Document explicitly at creation time, updated later, or be set automatically at creation if a Collection's ttl_days is set. We should add this common field to the Document class.

Solution

Add ttl as a public, optional field to the Document class.

Result

The ttl field can now be accessed in Typescript projects without adding it to user types.

Out of scope

N/A

Testing

Added unit and integration test.


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ptpaterson ptpaterson requested a review from cleve-fauna April 3, 2024 20:17
@ptpaterson ptpaterson requested a review from pnwpedro April 11, 2024 14:32
@ptpaterson ptpaterson merged commit 90499c5 into beta May 6, 2024
5 checks passed
@ptpaterson ptpaterson deleted the doc-ttl branch May 6, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants