adding server functionality, example project and some code improvements #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i have just seen that my commit also fixed #4 |
|
Hi, sorry for the late response. Thank you for your contribution! I will review it. |
|
Hey guys, do you have plans to merge this any time soon? Thanks. |
|
Sorry I have not really had time to properly review this code. But from what I see in the changes, it looks good. My only concern is about the I will merge this change. Sorry for taking so long. also, thanks for the contribution! |
|
@fajran thank you |
tobiaskohlbau
added a commit
to tobiaskohlbau/twirp
that referenced
this pull request
Jun 28, 2018
fajran/protoc-gen-twirp_java_jaxrs#5 added server functionality.
KarenEtheridg
pushed a commit
to KarenEtheridg/twirp
that referenced
this pull request
Feb 17, 2023
fajran/protoc-gen-twirp_java_jaxrs#5 added server functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
i added server functionality for #3, also i added a example project to show how it works