Feature/webpack3 #2574

themre · 2017-06-20T07:56:00Z

Since Webpack 3 is officially released, I created PR with WP3 bump.

themre · 2017-06-20T08:09:58Z

Any idea why flow server crashes?
https://ci.appveyor.com/project/gaearon/create-react-app-a3khu/build/1.0.973/job/26rbke41cigfacoe

shrynx · 2017-06-20T08:52:05Z

@themre Webpack 3's biggest feature being scopes, using ModuleConcatenationPlugin should be used. Also extract-text-plugin is noy yet compatible with webpack 3 webpack-contrib/extract-text-webpack-plugin#494

themre · 2017-06-20T08:53:56Z

yeah, I know, I just wanted to add feature by feature and see where it fails. and obviously it fails only by bumping :)

Timer · 2017-06-22T06:10:58Z

No need to worry about AppVeyor for now, it's pretty flaky because many tools don't support Windows as well as their macOS/nix counterparts.

Just try to get Travis passing. 😄

Thanks a lot for looking into this.

themre · 2017-06-22T06:12:01Z

thanks for the info! added ModuleConcatenationPlugin for when later. also noticed this:
webpack/webpack#5089

themre · 2017-06-22T06:14:08Z

I don't think it's appveyor now. noticed this also when running locally: Module not found: Can't resolve 'source-map-loader' in 'C:\projects\create-react-app-a3khu'. Do we need to add source-map-loader into dependencies?

Timer · 2017-06-22T06:14:32Z

Yeah, be advised that the ModuleConcatenationPlugin is still highly experimental.

We'll need to keep a close eye on webpack issues and run tests on large projects to find any edge cases. It may be too buggy to ship immediately.

Timer · 2017-06-22T06:16:05Z

Is there any reason you included the source-map-loader commit?
I'd say it's safe to remove that commit for now. I'd like for this PR to focus on webpack 3 and leave #2355 to focus on source-map-loader.

themre · 2017-06-22T06:20:05Z

strange, it merged that commit, but not package.json (which is missing import of source-map-loader). removed it for now.

Timer · 2017-06-22T06:23:40Z

Great! Thanks.

I see a warning:

Creating an optimized production build...
(node:4259) DeprecationWarning: Chunk.modules is deprecated. Use Chunk.getNumberOfModules/mapModules/forEachModule/containsModule instead.
Compiled successfully.

Would you mind taking a peek into this and identifying the offending module?

We need to compile a list of plugins that were broken and need updating by webpack 3.

Additionally, we need to compile a list of breaking changes in webpack@3 that may affect us.

themre · 2017-06-22T06:25:54Z

extract-text-webpack-plugin.
webpack-contrib/extract-text-webpack-plugin#494
PR is here: webpack-contrib/extract-text-webpack-plugin#543
let's wait for it and then bump it.

themre · 2017-06-22T06:26:51Z

@shrynx already mentioned it :) thanks!

gaearon

Thanks for working on it! Left a few comments.

gaearon · 2017-07-08T13:39:26Z

packages/react-scripts/config/webpack.config.dev.js

@@ -254,6 +254,7 @@ module.exports = {
    // Makes some environment variables available to the JS code, for example:
    // if (process.env.NODE_ENV === 'development') { ... }. See `./env.js`.
    new webpack.DefinePlugin(env.stringified),
+    new webpack.optimize.ModuleConcatenationPlugin(),


We shouldn't include this yet. It is too experimental.

gaearon · 2017-07-08T13:39:32Z

packages/react-scripts/config/webpack.config.prod.js

@@ -293,6 +293,7 @@ module.exports = {
      },
      sourceMap: true,
    }),
+    new webpack.optimize.ModuleConcatenationPlugin(),


gaearon · 2017-07-08T13:39:58Z

packages/react-scripts/package.json

-    "url-loader": "0.5.8",
-    "webpack": "2.6.1",
-    "webpack-dev-server": "2.4.5",
+    "react-dev-utils": "^3.0.2",


This is our own module. Please don't bump it now. It is bumped during the release.

gaearon · 2017-07-08T13:40:03Z

packages/react-scripts/package.json

-    "webpack": "2.6.1",
-    "webpack-dev-server": "2.4.5",
+    "react-dev-utils": "^3.0.2",
+    "react-error-overlay": "^1.0.9",


gaearon · 2017-07-08T13:40:23Z

packages/react-scripts/package.json

@@ -48,13 +48,13 @@
    "postcss-flexbugs-fixes": "3.0.0",


Shouldn't we need to bump ExtractTextPlugin?

themre · 2017-07-08T13:59:29Z

ok, I removed ModuleConcatenationPlugin, downgraded react packages and bumped ETWP.

themre · 2017-07-08T14:14:21Z

ETWP rc1 has been released. I updated it only to see if everything goes through so we can report if something else fails.

themre · 2017-07-21T20:13:45Z

It fails with 3.3.0. Will see if it fails with 3.2.0.

themre · 2017-07-22T15:34:04Z

hm... it's failing, because:

./src/features/webpack/assets/abstract.json
(Emitted value instead of an instance of Error) ⚠️  JSON Loader
It seems you're using webpack >= v2.0.0, which includes native support for JSON.
Please remove this loader from webpack.config.js as it isn't needed anymore and
is deprecated. See the v1.0.0 -> v2.0.0 migration guide for more information
(https://webpack.js.org/guides/migrating/#json-loader-is-not-required-anymore)
C:/Users/appveyor/AppData/Local/Temp/1/tmp.bNXBiS0bLw/node_modules/test-integrity/package.json
(Emitted value instead of an instance of Error) ⚠️  JSON Loader

It seems initDOM.js (https://github.com/facebookincubator/create-react-app/blob/a171d930641f513279b1c7ceaab1fa9bbbbbb896/packages/react-scripts/fixtures/kitchensink/integration/initDOM.js) tries to load json-loader which isn't required anymore. How do we approach this?

gaearon · 2017-07-22T16:52:43Z

Hmm I'm not sure where this is coming from 😞
Could this somehow be caused by this?

gaearon · 2017-07-22T16:59:21Z

I filed an issue in webpack-contrib/json-loader#57.

themre · 2017-07-22T17:00:10Z

great, thanks!

joshwiens · 2017-07-22T20:12:49Z

@themre - I stripped the deprecation warning in [email protected] which is now available on npm.

To the issue in CompatibilityPlugin.js i'll take that issue up on slack shortly.

In the mean time, i am locking json-loader until we resolve the issue upstream. It was deprecated, should be deprecated by can't be until Webpack doesn't directly depend on it.

themre · 2017-07-24T20:14:42Z

seems everything is ok now.

gaearon · 2017-07-25T19:29:06Z

Sweet. Wanna send another PR to bump to webpack 3.4 that just came out?

themre · 2017-07-25T20:18:25Z

#2850

Timer · 2017-08-09T03:49:56Z

Hi there! This change is out in [email protected]; please give it a go! Thanks.

* Add source-map-loader to support source maps of dependencies * merge with latest develop * add ModuleConcatenationPlugin * revert source-map-loader * bump to 3.1 and update dev-server * rebase to master * rebase again * bump webpack * remove ModuleConcatenationPlugin, downgraded react packages, bump etwp * ETWP rc1 only for testing * bump ETWP and webpack 3 * bump WP3 * revert to 3.2.0 * bump sw-precache-webpack-plugin * bump back to 3.3.0 * bump dev-server and manifest

ericvicenti and others added 4 commits May 24, 2017 17:14

Add source-map-loader to support source maps of dependencies

f1d8295

bump to WP3

1d15562

merge with latest develop

49a2bfc

Merge branch 'feature/webpack3' into develop

e26110b

facebook-github-bot added the CLA Signed label Jun 20, 2017

add ModuleConcatenationPlugin

a5ea7ba

revert source-map-loader

deede11

mihir0x69 mentioned this pull request Jun 24, 2017

Bump webpack to 3.0.0 and update related deps react-boilerplate/react-boilerplate#1823

Merged

Marko Trebizan added 4 commits July 7, 2017 07:58

bump to 3.1 and update dev-server

6aad3a2

rebase to master

280d2d7

rebase again

c6e68fa

bump webpack

c9b82af

gaearon suggested changes Jul 8, 2017

View reviewed changes

Marko Trebizan and others added 2 commits July 8, 2017 15:55

remove ModuleConcatenationPlugin, downgraded react packages, bump etwp

8230e8b

Merge branch 'master' into feature/webpack3

2c50764

ETWP rc1 only for testing

e0bce04

revert to 3.2.0

8d3e41f

bump sw-precache-webpack-plugin

caa126d

gaearon mentioned this pull request Jul 22, 2017

False positive warning about Webpack 2 webpack-contrib/json-loader#57

Closed

themre mentioned this pull request Jul 22, 2017

Depricated JSON Loader Warning when CI=true #2840

Closed

Marko Trebizan added 2 commits July 22, 2017 22:23

bump back to 3.3.0

651cd15

bump dev-server and manifest

f6b6935

gaearon added the tag: enhancement label Jul 25, 2017

gaearon added this to the 1.0.11 milestone Jul 25, 2017

gaearon approved these changes Jul 25, 2017

View reviewed changes

gaearon merged commit bc82755 into facebook:master Jul 25, 2017

themre deleted the feature/webpack3 branch July 25, 2017 19:45

ianschmitz mentioned this pull request Aug 4, 2017

Merge react-scripts with upstream wmonk/create-react-app-typescript#129

Closed

matthewdavidson mentioned this pull request Oct 25, 2017

[BPK-971] Upgrade webpack deps Skyscanner/backpack#224

Merged

lock bot locked and limited conversation to collaborators Jan 21, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/webpack3 #2574

Feature/webpack3 #2574

themre commented Jun 20, 2017

themre commented Jun 20, 2017

shrynx commented Jun 20, 2017

themre commented Jun 20, 2017

Timer commented Jun 22, 2017 •

edited

Loading

themre commented Jun 22, 2017

themre commented Jun 22, 2017

Timer commented Jun 22, 2017 •

edited

Loading

Timer commented Jun 22, 2017

themre commented Jun 22, 2017

Timer commented Jun 22, 2017 •

edited

Loading

themre commented Jun 22, 2017

themre commented Jun 22, 2017

gaearon left a comment

gaearon Jul 8, 2017

gaearon Jul 8, 2017

gaearon Jul 8, 2017

gaearon Jul 8, 2017

gaearon Jul 8, 2017

themre commented Jul 8, 2017

themre commented Jul 8, 2017

themre commented Jul 21, 2017

themre commented Jul 22, 2017

gaearon commented Jul 22, 2017

gaearon commented Jul 22, 2017

themre commented Jul 22, 2017

joshwiens commented Jul 22, 2017

themre commented Jul 24, 2017

gaearon commented Jul 25, 2017

themre commented Jul 25, 2017

Timer commented Aug 9, 2017

Feature/webpack3 #2574

Feature/webpack3 #2574

Conversation

themre commented Jun 20, 2017

themre commented Jun 20, 2017

shrynx commented Jun 20, 2017

themre commented Jun 20, 2017

Timer commented Jun 22, 2017 • edited Loading

themre commented Jun 22, 2017

themre commented Jun 22, 2017

Timer commented Jun 22, 2017 • edited Loading

Timer commented Jun 22, 2017

themre commented Jun 22, 2017

Timer commented Jun 22, 2017 • edited Loading

themre commented Jun 22, 2017

themre commented Jun 22, 2017

gaearon left a comment

Choose a reason for hiding this comment

gaearon Jul 8, 2017

Choose a reason for hiding this comment

gaearon Jul 8, 2017

Choose a reason for hiding this comment

gaearon Jul 8, 2017

Choose a reason for hiding this comment

gaearon Jul 8, 2017

Choose a reason for hiding this comment

gaearon Jul 8, 2017

Choose a reason for hiding this comment

themre commented Jul 8, 2017

themre commented Jul 8, 2017

themre commented Jul 21, 2017

themre commented Jul 22, 2017

gaearon commented Jul 22, 2017

gaearon commented Jul 22, 2017

themre commented Jul 22, 2017

joshwiens commented Jul 22, 2017

themre commented Jul 24, 2017

gaearon commented Jul 25, 2017

themre commented Jul 25, 2017

Timer commented Aug 9, 2017

Timer commented Jun 22, 2017 •

edited

Loading

Timer commented Jun 22, 2017 •

edited

Loading

Timer commented Jun 22, 2017 •

edited

Loading