Create a nothrow task with tests #540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
ispeters
reviewed
Jun 15, 2023
ispeters
reviewed
Jun 21, 2023
ispeters
approved these changes
Jun 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modifies task.hpp to include nothrow_task. The behavior for nothrow_task and task.hpp is mostly the same, with the difference being nothrow_task calling std::terminate when an exception is thrown. Part of the motivation is to create a task that's smaller in binary size compared to task by minimizing the use of exceptions.
The other difference is that the scheduler affinity in nothrow_task and task is slightly different, as illustrated by the tests.