Skip to content
This repository has been archived by the owner on Mar 3, 2020. It is now read-only.

Incompatibility with the Facebook library Flipper #198

Open
FBisca opened this issue Aug 20, 2018 · 0 comments
Open

Incompatibility with the Facebook library Flipper #198

FBisca opened this issue Aug 20, 2018 · 0 comments

Comments

@FBisca
Copy link

FBisca commented Aug 20, 2018

We are trying to add the facebook library Flipper in our project (https://github.com/facebook/flipper)

And I noticed that Conceal uses the same classes/jni as Flipper but instead of adding them as a transitive dependency, they are added as sourceSets.

conceal/build.gradle

sourceSets {

      main {
        manifest.srcFile 'AndroidManifest.xml'
        java.srcDirs = [
            'first-party/fbjni/java',
            'first-party/proguard/annotations',
            'first-party/soloader',
            'java']
        jniLibs.srcDir 'libs'
        jni.srcDirs = []
      }
    }

This is what happens when we are using Conceal together with Flipper:

myProject/build.gradle

implementation "com.facebook.conceal:conceal:2.0.1@aar"
debugImplementation('com.facebook.sonar:sonar:0.6.13')

Compilation Error

AGPBI: {"kind":"error","text":"Program type already present: com.facebook.jni.IteratorHelper","sources":[{}],"tool":"D8"}

Transitive dependencies from Flipper

+--- com.facebook.sonar:sonar:0.6.13
|    +--- com.facebook.sonar:fbjni:0.6.13
|    |    \--- com.facebook.soloader:soloader:0.5.1
|    +--- com.facebook.soloader:soloader:0.5.1

I tried to exclude the transitive dependencies from Flipper but it seems that the Conceal don't have all the .so files needed.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant