Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use FB specific stream config for native-relay #24322

Closed
wants to merge 1 commit into from

Conversation

sebmarkbage
Copy link
Collaborator

This is not really used yet but for parity with the dom-relay implementation this should use the FB-specific fake stream protocol and not the Node protocol. For Server Components for Native.

This is not really used yet but for parity with the dom-relay
implementation.
@sizebot
Copy link

sizebot commented Apr 9, 2022

Comparing: b0f13e5...d00b9cc

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 131.28 kB 131.28 kB = 41.94 kB 41.94 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 136.55 kB 136.55 kB = 43.53 kB 43.53 kB
facebook-www/ReactDOM-prod.classic.js = 435.21 kB 435.21 kB = 79.86 kB 79.86 kB
facebook-www/ReactDOM-prod.modern.js = 420.20 kB 420.20 kB = 77.49 kB 77.49 kB
facebook-www/ReactDOMForked-prod.classic.js = 435.21 kB 435.21 kB = 79.86 kB 79.86 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
facebook-relay/flight/ReactFlightNativeRelayServer-dev.js = 38.79 kB 38.65 kB = 9.87 kB 9.81 kB

Generated by 🚫 dangerJS against d00b9cc

@sebmarkbage
Copy link
Collaborator Author

sebmarkbage commented Apr 9, 2022

Ah. Now I remember why this doesn't work yet. Because the RN protocol is binary and the FB infra doesn't yet have support for binary (typed arrays).

@gnoff
Copy link
Collaborator

gnoff commented Apr 11, 2022

@sebmarkbage should we close this?

@sebmarkbage
Copy link
Collaborator Author

I'm not quite sure how to move forward with this. We probably need to disable this option somehow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants