Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhancement] HTML/XML comment support for JSX #7201

Closed
pke opened this issue Jul 6, 2016 · 2 comments
Closed

[enhancement] HTML/XML comment support for JSX #7201

pke opened this issue Jul 6, 2016 · 2 comments

Comments

@pke
Copy link

pke commented Jul 6, 2016

Feature

Support XML <!-- --> comments in JSX

Current status

Currently the only way to insert comments into JSX flow is to wrap them in JS:

{/**/}

In context:

<Foo>
  {/* I will tell you why this component is here */}
  <Bar>
  </Bar>
</Foo>

Proposed extension

XML like comments.

<Foo>
  <!-- I will tell you why this component is here -->
  <Bar>
  </Bar>
</Foo>

This would also allow us to quickly temporarily comment out components in the JSX flow like this:

<Foo>
  <!--Bar>
  </Bar-->
</Foo>
@gaearon
Copy link
Collaborator

gaearon commented Jul 6, 2016

Thanks for the proposal!
https://github.com/facebook/jsx would be the right place to discuss this.
There is an issue on this (facebook/jsx#7) so you can voice support there.

@gaearon gaearon closed this as completed Jul 6, 2016
@pke
Copy link
Author

pke commented Jul 6, 2016

ah you right, sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants