-
Notifications
You must be signed in to change notification settings - Fork 47.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Several tests fail on main with Node v16 #24915
Comments
Which specific node version is causing issues? |
From the previous issue I linked:
|
16.10 was released september 2021. Does the issue persist if you switch to the latest 16.x minor i.e. 16.16? |
This is an issue with all 16.x and higher due to a change in the underlying error messages from node; as the previously linked issue describes in more detail, which is why I linked it for context on the issue.. |
This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment! |
Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you! |
There was a previous issue opened for this, which had a solution implemented by @bvaughn to resolve, but there still seem to be some edgecases remaining:
Currently the CircleCI seems to only run tests on one node version (as I discovered while looking into #24891). I wonder if it would make sense to run them in the CI for all node versions include in the
package.json
devEngines.node
; to proactively catch edgecases like this.The text was updated successfully, but these errors were encountered: