Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[React DevTools] Warn for Duplicate DevTools Installations #24157

Closed
3 tasks
lunaruan opened this issue Mar 24, 2022 · 3 comments
Closed
3 tasks

[React DevTools] Warn for Duplicate DevTools Installations #24157

lunaruan opened this issue Mar 24, 2022 · 3 comments
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity

Comments

@lunaruan
Copy link
Contributor

lunaruan commented Mar 24, 2022

If there are duplicate installations of DevTools (ex. if there is an internal version of DevTools installed alongside the Chrome Web Store extension), we currently produce a stream of errors that renders DevTools unusable. Previously, we tried to fix this here by detecting duplicate DevTools versions and preventing them from erroring. However, because there are some edge cases with code that extends the DevTools hook, we had to revert this change.

Even though we're unable to prevent these errors completely, it would be useful to warn the user that they might have duplicate installations of DevTools. We probably don't want to bother the user with this warning multiple times, so we should only warn the first time we detect the duplicate version.

For this task:

  • Show a warning dialog if there are duplicate DevTools versions installed. You can use this PR for guidance
  • Write a value to localStorage once this warning has been shown so that we don't continue to show it if the user chooses to leave the duplicate extension installed.
  • Clear the localStorage value if the duplicate extension is no longer detected. (This will let us show the dialog if the duplicate is ever accidentally re-installed.)
@scyron6
Copy link
Contributor

scyron6 commented Apr 4, 2022

I will work on this.

Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

No branches or pull requests

2 participants