Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DevTools: Re-think errors/warnings that do not have a 1:1 component mapping #20684

Closed
bvaughn opened this issue Jan 28, 2021 · 2 comments
Closed
Assignees
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Jan 28, 2021

#20463 added an option to display errors and warnings related to React components directly within the DevTools Components tree. The mechanism for associating an error or warning with a React component was to check if any Fiber was currently being rendered.

However this doesn't work for all types of warnings. For example, many strict mode warnings are not logged during render (per component), but instead are coalesced and logged as a group when the render work is committed. This was done to reduce the number of warnings React logged to the console. A side effect of this though is that DevTools isn't able to associate the warning with any components and so it does not get surfaced in the UI.

We should come up with a design that is able to handle errors/warnings that have a 1:many component mapping (like strict mode), as well as ones that might not even make sense to show in the Components tree at all (like hydration errors).

@bvaughn bvaughn self-assigned this Jan 28, 2021
@bvaughn bvaughn changed the title DevTools: Strict mode warnings should be inline with a component too DevTools: Re-think errors/warnings that do not have a 1:1 component mapping Jan 28, 2021
Copy link

This issue has been automatically marked as stale. If this issue is still affecting you, please leave any comment (for example, "bump"), and we'll keep it open. We are sorry that we haven't been able to prioritize it yet. If you have any new additional information, please include it with your comment!

@github-actions github-actions bot added the Resolution: Stale Automatically closed due to inactivity label Apr 10, 2024
Copy link

Closing this issue after a prolonged period of inactivity. If this issue is still present in the latest release, please create a new issue with up-to-date information. Thank you!

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Developer Tools Resolution: Stale Automatically closed due to inactivity
Projects
None yet
Development

No branches or pull requests

1 participant