Skip to content

Commit

Permalink
[Fizz] Remove assignID mechanism (#22410)
Browse files Browse the repository at this point in the history
* Remove pushEmpty

This is only used to support the assignID mechanism.

* Remove assignID mechanism

This effectively isn't used anyway because we always insert a dummy tag
into the fallback.

* Emit the template tag with an ID directly in pending boundaries

This ensures that assigning the ID is deterministic since it's done during
writing.

This also avoids emitting it for client rendered boundaries that start as
client rendered since we never need to refer to them.

* Move lazy ID initialization to the core implementation

We never need an ID before we write a pending boundary. This also ensures
that ID generation is deterministic by moving it to the write phase.

* Simplify the inserted scripts

We can assume that there are no text nodes before the template tag so this
simplifies the script that finds the comment node. It should be the direct
previous child.
  • Loading branch information
sebmarkbage authored Sep 24, 2021
1 parent 1c58cfa commit d47339e
Show file tree
Hide file tree
Showing 6 changed files with 73 additions and 278 deletions.
Loading

0 comments on commit d47339e

Please sign in to comment.