From adb58f529d861882418274966f53767f60501c01 Mon Sep 17 00:00:00 2001 From: Jan Kassens Date: Tue, 4 Oct 2022 11:04:43 -0400 Subject: [PATCH] Flow upgrade to 0.152 - 0.147 removes access to Object.prototype via the global object. - 0.149 removed deprecated config options ghstack-source-id: c77f9b3739796547dd2d82a549b6dc24d502af54 Pull Request resolved: https://github.com/facebook/react/pull/25411 --- package.json | 2 +- .../src/devtools/views/Components/KeyValue.js | 2 ++ .../react-devtools-shared/src/devtools/views/utils.js | 2 ++ packages/react-devtools-shared/src/utils.js | 2 ++ scripts/flow/config/flowconfig | 5 +---- yarn.lock | 9 +++++---- 6 files changed, 13 insertions(+), 9 deletions(-) diff --git a/package.json b/package.json index 5b870e97c3308..22d9bc8dfe6a9 100644 --- a/package.json +++ b/package.json @@ -63,7 +63,7 @@ "eslint-plugin-react-internal": "link:./scripts/eslint-rules", "fbjs-scripts": "1.2.0", "filesize": "^6.0.1", - "flow-bin": "^0.146.0", + "flow-bin": "^0.152.0", "glob": "^7.1.6", "glob-stream": "^6.1.0", "google-closure-compiler": "^20200517.0.0", diff --git a/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js b/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js index 1da9920566d31..e11d4e712bcef 100644 --- a/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js +++ b/packages/react-devtools-shared/src/devtools/views/Components/KeyValue.js @@ -33,6 +33,8 @@ import type {Element} from 'react-devtools-shared/src/devtools/views/Components/ import type {Element as ReactElement} from 'react'; import type {FrontendBridge} from 'react-devtools-shared/src/bridge'; +const hasOwnProperty = Object.prototype.hasOwnProperty; + type Type = 'props' | 'state' | 'context' | 'hooks'; type KeyValueProps = { diff --git a/packages/react-devtools-shared/src/devtools/views/utils.js b/packages/react-devtools-shared/src/devtools/views/utils.js index ae9c4ddff309c..ab0986736bef0 100644 --- a/packages/react-devtools-shared/src/devtools/views/utils.js +++ b/packages/react-devtools-shared/src/devtools/views/utils.js @@ -14,6 +14,8 @@ import isArray from 'react-devtools-shared/src/isArray'; import type {HooksTree} from 'react-debug-tools/src/ReactDebugHooks'; +const hasOwnProperty = Object.prototype.hasOwnProperty; + export function alphaSortEntries( entryA: [string, mixed], entryB: [string, mixed], diff --git a/packages/react-devtools-shared/src/utils.js b/packages/react-devtools-shared/src/utils.js index 36063f4f0e0c4..71d0f283ef640 100644 --- a/packages/react-devtools-shared/src/utils.js +++ b/packages/react-devtools-shared/src/utils.js @@ -56,6 +56,8 @@ import isArray from './isArray'; import type {ComponentFilter, ElementType} from './types'; import type {LRUCache} from 'react-devtools-shared/src/types'; +const hasOwnProperty = Object.prototype.hasOwnProperty; + const cachedDisplayNames: WeakMap = new WeakMap(); // On large trees, encoding takes significant time. diff --git a/scripts/flow/config/flowconfig b/scripts/flow/config/flowconfig index 8473008b31a5c..20ff77029f208 100644 --- a/scripts/flow/config/flowconfig +++ b/scripts/flow/config/flowconfig @@ -40,9 +40,6 @@ untyped-type-import=error [options] %CI_MAX_WORKERS% -esproposal.class_static_fields=enable -esproposal.class_instance_fields=enable -esproposal.optional_chaining=enable exact_by_default=true munge_underscores=false @@ -50,4 +47,4 @@ munge_underscores=false %REACT_RENDERER_FLOW_OPTIONS% [version] -^0.146.0 +^0.152.0 diff --git a/yarn.lock b/yarn.lock index e3154c895de7e..f85d9cf0011d2 100644 --- a/yarn.lock +++ b/yarn.lock @@ -6901,6 +6901,7 @@ eslint-plugin-no-unsanitized@3.1.2: "eslint-plugin-react-internal@link:./scripts/eslint-rules": version "0.0.0" + uid "" eslint-plugin-react@^6.7.1: version "6.10.3" @@ -7911,10 +7912,10 @@ flatted@^2.0.0: resolved "https://registry.yarnpkg.com/flatted/-/flatted-2.0.2.tgz#4575b21e2bcee7434aa9be662f4b7b5f9c2b5138" integrity sha512-r5wGx7YeOwNWNlCA0wQ86zKyDLMQr+/RB8xy74M4hTphfmjlijTSSXGuH8rnvKZnfT9i+75zmd8jcKdMR4O6jA== -flow-bin@^0.146.0: - version "0.146.0" - resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.146.0.tgz#fafa002663a0e13bf3c08c3972dd93d68289ccc6" - integrity sha512-TP8eCwltqc7fo6ad5klgsrZ2veZIK2qM1vHf1A/cnXTStPh8hLAz1cOXmlQIFZR/7fjSMI39TS3CgF6M/HUhAw== +flow-bin@^0.152.0: + version "0.152.0" + resolved "https://registry.yarnpkg.com/flow-bin/-/flow-bin-0.152.0.tgz#6980d0cd58f59e9aefd580b11109a1d56eba46b1" + integrity sha512-b4ijbZIQovcx5l/T7VnwyBPIikj60A2qk7hKqQKVWiuftQMrUmC5ct2/0SuVvheX6ZbPdZfeyw2EHO1/n3eAmw== fluent-syntax@0.13.0: version "0.13.0"