Replace deprecated stringByReplacingPercentEscapesUsingEncoding: with stringByAddingPercentEncodingWithAllowedCharacters:

[pvinis]

Replace some NSString deprecated methods.
motivation for these prs is less warnings reported on xcode everytime we compile a rn app.

Test Plan

N/A

Release Notes

[INTERNAL] [DEPRECATIONS] [NSString] - Replace NSString deprecation methods.

[pull-bot]

	Warnings
⚠️	📋 Changelog - This PR appears to be missing Changelog. Please add a section called "changelog" and format it as explained in the contributing guidelines.

Generated by 🚫 dangerJS

[janicduplessis]

Looks good! Thanks for the fixes :)

@facebook-github-bot shipit

[facebook-github-bot]

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[facebook-github-bot]

I tried to merge this pull request into the Facebook internal repo but some checks failed. To unblock yourself please check the following: Does this pull request pass all open source tests on GitHub? If not please fix those. Does the code still apply cleanly on top of GitHub master? If not can please rebase. In all other cases this means some internal test failed, for example a part of a fb app won't work with this pull request. I've added the Import Failed label to this pull request so it is easy for someone at fb to find the pull request and check what failed. If you don't see anyone comment in a few days feel free to comment mentioning one of the core contributors to the project so they get a notification.

[pvinis]

hmm.. tests here pass. would be nice to see what the problematic internal test is. if it's not sensitive, maybe we could open source it? any ideas what could it be @janicduplessis ?

[janicduplessis]

Sorry about the delay, it failed to import into the internal fb repo, I'll try landing again and if it doesn't work I'll ping someone at fb.

[janicduplessis]

@facebook-github-bot shipit

[facebook-github-bot]

@janicduplessis is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Let's try this again!

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[cpojer]

Just getting back to this. Thanks for submitting this PR. Unfortunately it seems that unit tests are failing:

Failure: ((result.absoluteString) equal to (@"http://example.com/blah%20blah/foo")) failed: ("http%3A%2F%2Fexample.com%2Fblah%20blah%2Ffoo") is not equal to ("http://example.com/blah%20blah/foo")
Path: react-native/RNTester/RNTesterUnitTests/RCTConvert_NSURLTests.m
Line Number: 54

This is the file specifically: https://github.com/facebook/react-native/blob/master/RNTester/RNTesterUnitTests/RCTConvert_NSURLTests.m

Would you mind doing another pass and fixing those issues, then we can finally land it? Again, sorry for the long wait on this :(

[pvinis]

I'll try it now and get back to you.

[pvinis]

This was a good catch actually. I changed the allowed characters to be the ones they should be for each case, ran all the tests and now all is well here.

I was thinking of putting the character set into a category of NSCharacterSet but I don't know if you want that or if there is a place for categories etc. Let me know what you think, but I'm happy another one of my PRs is soon in the core code :D

[facebook-github-bot]

@cpojer is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.

[react-native-bot]

@pvinis merged commit 61ca119 into facebook:master.