Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discussion: RN Should not be prompting users to switch over to the community slider version of the package until it's more stable #24719

Closed
bobber205 opened this issue May 6, 2019 · 1 comment
Labels
Component: Slider Component: Switch Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.

Comments

@bobber205
Copy link

Good day RN community.

I have appreciated greatly the suggestions on "hey this package is getting removed in an upcoming RN version, using this extracted version instead". I totally get what RN is doing this.

However I'm come across an instance of advice that I don't think should be presented to developers (just yet)

https://github.com/react-native-community/react-native-slider

When using the react-native version of the Slider component you get the typical use the above version instead. Unfortunately this version is largely broken at the moment. Using the latest and greatest of CLI tools and RN I am not able to easily run react-native link @react-native-community/slider and have it work. Sure the command runs fine but then you're basically guaranteed to run into this: callstack/react-native-slider#41

I think until that package is more stable/fixed that warning shouldn't come up. There are surely many devs out there making the same mistakes as me and wasting precious man hours trying to debug what they did wrong.

:)

@hramos
Copy link
Contributor

hramos commented May 6, 2019

While I am not familiar with the specific case of react-native-slider, in theory what is being extracted to the community package is the same component that already existed in React Native core. All that is changing is that you're now importing the package from the community-managed repository. In fact, exporting the package into its own repository will allow the community to move faster and fix the issues you bring up here. I'm not sure that leaving the package in core would help in this case.

In any case, this seems like a more appropriate discussion for the existing Lean Core thread: #23313

@hramos hramos closed this as completed May 6, 2019
@facebook facebook locked as resolved and limited conversation to collaborators May 6, 2020
@react-native-bot react-native-bot added the Resolution: Locked This issue was locked by the bot. label May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Component: Slider Component: Switch Resolution: Locked This issue was locked by the bot. Type: Discussion Long running discussion.
Projects
None yet
Development

No branches or pull requests

3 participants