chore: default to node test env rather than browser #9874
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
We need to make sure this is properly announced and have tools like CRA be informed. |
|
Error message thing worked 😀
|
SimenB
force-pushed
the
default-node-test-env
branch
3 times, most recently
from
402f7f3 to
b7df539
Compare
|
Let's do this in 27, it's a big deal and needs to be communicated. |
SimenB
force-pushed
the
default-node-test-env
branch
from
b7df539 to
24b421e
Compare
|
Could we put configuration advice including |
|
Sure! You up for a PR? |
|
How is the error being created? I don't think I'm seeing it in this PR. |
|
The error message was added in #8245 |
SimenB
force-pushed
the
default-node-test-env
branch
from
24b421e to
fbfe79b
Compare
SimenB
force-pushed
the
default-node-test-env
branch
from
fbfe79b to
af4cec4
Compare
SimenB
force-pushed
the
default-node-test-env
branch
from
af4cec4 to
f3232ff
Compare
jeysal
added a commit
to mmkal/jest
that referenced
this pull request
Nov 8, 2020
* master: (398 commits) chore(breaking): remove undocumented `enabledTestsMap` config (jestjs#10787) Change expect.not.objectContaining() to match documentation (jestjs#10708) chore: add name to root project (jestjs#10782) Added explanation on how to use custom @jest-environment to docs (jestjs#10783) fix: remove deprecated functions from the jest object (jestjs#9853) chore: convert jest-runtime to ESM (jestjs#10325) fix(resolve): use escalade to find package.json (jestjs#10781) feat(jest-runner): set exit code to 1 if test logs after teardown (jestjs#10728) chore: add `exports` field to all `package.json`s (jestjs#9921) fix: do not inject `global` variable into module wrapper (jestjs#10644) chore: migrate jest-resolve to ESM (jestjs#10688) chore(transform): refactor API to pass an options bag around rather than multiple boolean options (jestjs#10753) chore: default to node test env rather than browser (jestjs#9874) fix: drop support for node 13 (jestjs#10685) chore: show enhanced syntax error for all syntax errors (jestjs#10749) chore: update lockfile after publish v26.6.3 chore: update changelog for release Don't throw an error if mock dependency can't be found (jestjs#10779) chore: bump babel core types (jestjs#10772) ...
Merged
2 tasks
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5815.
Test plan
🤷