Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[jest-haste-map] Remove mapper option. #9581

Merged
merged 1 commit into from
Feb 17, 2020
Merged

[jest-haste-map] Remove mapper option. #9581

merged 1 commit into from
Feb 17, 2020

Conversation

cpojer
Copy link
Member

@cpojer cpojer commented Feb 17, 2020

Summary

This option was added a while back to support some use-cases with Yarn PnP but it was neither documented nor is this how I would solve the problem of files not being materialized as this functionality has the potential to de-opt operations in Jest's haste map.

This PR removes the option.

Test plan

yolo

@SimenB SimenB added this to the Jest 26 milestone Feb 17, 2020
@thymikee
Copy link
Collaborator

cc @arcanis

@arcanis
Copy link
Contributor

arcanis commented Feb 17, 2020

Thanks for the ping - Yarn doesn't rely on this option, lgtm 👍

@codecov-io
Copy link

Codecov Report

Merging #9581 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9581      +/-   ##
==========================================
+ Coverage   65.07%   65.08%   +<.01%     
==========================================
  Files         286      286              
  Lines       12144    12137       -7     
  Branches     3010     3007       -3     
==========================================
- Hits         7903     7899       -4     
+ Misses       3605     3604       -1     
+ Partials      636      634       -2
Impacted Files Coverage Δ
packages/jest-haste-map/src/index.ts 81.26% <ø> (ø) ⬆️
packages/jest-haste-map/src/crawlers/watchman.ts 88.65% <100%> (+0.19%) ⬆️
packages/expect/src/utils.ts 96.22% <0%> (+1.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63593a2...05dd38b. Read the comment docs.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.
Please note this issue tracker is not a help forum. We recommend using StackOverflow or our discord channel for questions.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants