-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add buildDefaultResolverRequire
#9194
feat: add buildDefaultResolverRequire
#9194
Conversation
Once merged this can replace the following: https://github.com/facebook/jest/pull/8823/files#diff-58a3d284e2756ef4ee9dc82e73044b64R111-R114 https://github.com/facebook/jest/pull/8829/files#diff-79e46c9e92027daadc4fc85b7b71ae2dR27-R32 https://github.com/facebook/jest/pull/8854/files#diff-6fc504657ed2c7549c757bbfd2ebc6bfR179-R181 https://github.com/facebook/jest/pull/8751/files#diff-58a3d284e2756ef4ee9dc82e73044b64R106-R108 i.e /cc @M4rk9696 |
Codecov Report
@@ Coverage Diff @@
## master #9194 +/- ##
==========================================
- Coverage 65.1% 65.06% -0.05%
==========================================
Files 278 278
Lines 11860 11865 +5
Branches 2923 2925 +2
==========================================
- Hits 7722 7720 -2
- Misses 3511 3517 +6
- Partials 627 628 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be exported from packages/jest-transform/src/index.ts
. Also needs a changelog entry. It adds a public function, so I think it deserves its own mention
buildDefaultResolverRequire
functionbuildDefaultResolverRequire
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
This is a breaking out of
buildDefaultResolverRequire
from #8829 as requested@SimenB I've not written tests or add an entry in the changelog as it seemed like a bit of overkill for something that is going to be used in future PRs.
I did a sweep of the codebase, and the only place this could actually be used right now is in
jest-core
, but that'd require implementing support for the callback parameters 🤷♀It'll be nice to trim down the transformer PRs a bit :)